This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Clojure] follow up pr 14531 to fix tests #14565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Chouffe would you mind taking a look and reviewing this when you get a chance? |
|
@gigasquid I will take a look shortly when I get a chance. Thanks for finishing the fixes ^^ |
Chouffe
reviewed
Mar 29, 2019
| @@ -35,3 +35,4 @@ | |||
| ndarray-or-double-or-float | |||
| #{"org.apache.mxnet.MX_PRIMITIVES$MX_PRIMITIVE_TYPE" | |||
| "org.apache.mxnet.NDArray"}))))) | |||
|
|
|||
There was a problem hiding this comment.
#nitpick do we need this extra line?
There was a problem hiding this comment.
It's in the generator - not needed but we can tackle that in another PR touching that area.
Chouffe
approved these changes
Mar 29, 2019
| (m/forward data-batch)) | ||
| ;; FIXME | ||
| #_(is (= [(first l-shape) num-class] | ||
| (m/forward data-batch-2)) |
|
@mxnet-label-bot add [Clojure, test] |
|
Thanks for reviewing @Chouffe ! |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up PR to #14531 which fixed some Clojure tests that were not testing what they thought they were.
This PR resolves the FIXME disabled tests in there