Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

example/ssd/evaluate/eval_metric.py #14561

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Conversation

sunrongda
Copy link
Contributor

Description

(Brief description on what this PR is about)
image
this sort nothing to do gets,after sort gets didn't change

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@sunrongda sunrongda requested a review from szha as a code owner March 29, 2019 10:49
@abhinavs95
Copy link
Contributor

Thank you for contributing @sunrongda

@mxnet-label-bot add [Example, pr-awaiting-review]

@marcoabreu marcoabreu added Example pr-awaiting-review PR is waiting for code review labels Mar 29, 2019
@abhinavs95
Copy link
Contributor

@szha @zhreshold Could you help review?

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the fix!
Could you please provide the change of MAP before and after the fix?

@sunrongda
Copy link
Contributor Author

Could you please provide the change of MAP before and after the fix?
this is my
image

this is no change map
image
this is after change map
image
As you can see, map changes a lot.

@zhreshold zhreshold merged commit 33b6543 into apache:master Apr 1, 2019
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
* eval_metric.py

* Update eval_metric.py

* Update eval_metric.py
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* eval_metric.py

* Update eval_metric.py

* Update eval_metric.py
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* eval_metric.py

* Update eval_metric.py

* Update eval_metric.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Example pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants