Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[clojure][image] add draw-bounding-box interop #14533

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

Chouffe
Copy link
Contributor

@Chouffe Chouffe commented Mar 26, 2019

Description

How it was tested

pug-cookie-4

(-> image-path
    cv/imread
    (cvu/mat-to-buffered-image)
    (draw-bounding-box! [{:xmin 190 :xmax 850 :ymin 50 :ymax 450}
                         {:xmin 200 :xmax 350 :ymin 440 :ymax 530}]
                        {:stroke 2
                         :names ["pug" "cookie"]
                         :transparency 0.8
                         :font-size-mult 2.0})
    (cvu/buffered-image-to-mat)
    (cv/imwrite "pug-cookie-bounding-boxes.jpg"))

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Clojure, pr-awaiting-review]

@marcoabreu marcoabreu added Clojure pr-awaiting-review PR is waiting for code review labels Mar 26, 2019
@gigasquid
Copy link
Member

Thanks for this contribution. Will take a closer look in a bit 😸

Copy link
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! thanks!

@@ -199,3 +200,68 @@
[input]
(util/validate! ::to-image-ndarray input "Invalid input array")
(Image/toImage input))

(s/def ::buffered-image #(instance? BufferedImage %))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice specs 😍

`stroke`: positive integer - thickness of the bounding box
`transparency`: float in (0.0, 1.0) - Transparency of the bounding box
returns: Modified `buffered-image`
Ex:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the examples in the docstring

@gigasquid gigasquid merged commit 4d04238 into apache:master Mar 29, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* [clojure][image] add draw-bounding-box interop

* [clojure][image] add more specs and type conversion
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
* [clojure][image] add draw-bounding-box interop

* [clojure][image] add more specs and type conversion
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* [clojure][image] add draw-bounding-box interop

* [clojure][image] add more specs and type conversion
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* [clojure][image] add draw-bounding-box interop

* [clojure][image] add more specs and type conversion
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Clojure pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Clojure] - Add Draw Bounding Box to Core Clojure Image namespace
4 participants