Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] fix shape ndim out-of-bound bug #14518

Merged
merged 5 commits into from
Apr 24, 2019
Merged

Conversation

eric-haibin-lin
Copy link
Member

Description

Fix a bug in the iterator which is uncovered by the numpy branch. It used to cause undefined behavior in memory. No new test is added. @reminisce

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@lanking520
Copy link
Member

please do a pull --rebase to pass the CI

@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [Bug, Backend, pr-awaiting-response]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet Bug pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Mar 26, 2019
@Roshrini Roshrini added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Apr 16, 2019
@wkcn wkcn merged commit 3b39c56 into apache:master Apr 24, 2019
@wkcn
Copy link
Member

wkcn commented Apr 24, 2019

Merged. Thank you!

@eric-haibin-lin eric-haibin-lin deleted the idx-fix branch April 28, 2019 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet Bug pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants