Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Updated documentation about nightly tests #14493

Merged
merged 4 commits into from
Apr 3, 2019
Merged

Conversation

lebeg
Copy link
Contributor

@lebeg lebeg commented Mar 21, 2019

Description

Updated links to new nightly jobs.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pinaraws
Copy link

@mxnet-label-bot add[pr-awaiting-review, Test, CI]

@marcoabreu marcoabreu added CI pr-awaiting-review PR is waiting for code review Test labels Mar 25, 2019
@lebeg
Copy link
Contributor Author

lebeg commented Mar 25, 2019

@aaronmarkham

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor suggestions... otherwise it's fine.

tests/nightly/README.md Outdated Show resolved Hide resolved
tests/nightly/README.md Outdated Show resolved Hide resolved
tests/nightly/README.md Outdated Show resolved Hide resolved
@aaronmarkham aaronmarkham merged commit 28fe552 into apache:master Apr 3, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* Updated documentation about nightly tests

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Updated documentation about nightly tests

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>

* Update tests/nightly/README.md

Co-Authored-By: lebeg <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants