Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixes the test_sgld #14473

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Fixes the test_sgld #14473

merged 2 commits into from
Mar 20, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Mar 19, 2019

Description

Fixes #14241
The original test failed with float16.
Adjusted the tolerance level of float16 following Fixing Flaky Tests
The test passed after 10k runs.

MXNET_TEST_COUNT=10000 nosetests -v test_operator_gpu.py:test_sgld
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=908073956 to reproduce.
test_operator_gpu.test_sgld ... ok

----------------------------------------------------------------------
Ran 1 test in 8554.348s

OK

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@pinaraws
Copy link

pinaraws commented Mar 19, 2019

Thank you for your contribution @stu1130!
Some tests are failing, please have a look.

@mxnet-label-bot add[pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Mar 19, 2019
@TaoLv
Copy link
Member

TaoLv commented Mar 20, 2019

Thank you for the contribution. Merged.

@TaoLv TaoLv merged commit 56b7b67 into apache:master Mar 20, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* fix the test_sgld

* retrigger CI
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
* fix the test_sgld

* retrigger CI
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* fix the test_sgld

* retrigger CI
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* fix the test_sgld

* retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: sgld
5 participants