This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix relative difference scala #14417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
reviewed
Mar 13, 2019
| @@ -335,7 +335,7 @@ class NDArraySuite extends FunSuite with BeforeAndAfterAll with Matchers { | |||
| } | |||
|
|
|||
| test("arange") { | |||
| for (i <- 0 until 5) { | |||
| for (i <- 0 until 10000) { | |||
There was a problem hiding this comment.
Instead of increasing the number of iterations, could you maybe add a test case that specifically hits the behaviour you're trying to circumvent here?
There was a problem hiding this comment.
Sure. That's definitely a better solution.
There was a problem hiding this comment.
@lanking520 @nswamy could you give me a hand here and review the scala code?
|
Thanks a lot for your contribution - nice catch! |
marcoabreu
approved these changes
Mar 13, 2019
|
Oops |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Fix relative difference scala * Increase number of cases for scala arange test * Add cases where arange produces NDArray of [0] * Remote whitespace
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Fix relative difference scala * Increase number of cases for scala arange test * Add cases where arange produces NDArray of [0] * Remote whitespace
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Fix relative difference scala * Increase number of cases for scala arange test * Add cases where arange produces NDArray of [0] * Remote whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14402 where division by zero occurs in relative difference calculation, making
arangetests fail.Solution: if
diffis near 0f, i.e <Float.MinPositiveValuejust return it instead of dividing bynorm.Also
increase number of test cases to 10000add test cases wherearangeproduces NDArray of [0.0f] to catch this. Test is not flaky anymore.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
#14413 @lanking520 @perdasilva