Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add proper exception message for negative shape in array creation routines #14362

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented Mar 8, 2019

Description

Fixes #9166
Addresses @apeforest 's comment and adds a relevant exception message when negative shapes are passed to operators like ones and zeros

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • add a LOG(FATAL) message

Comments

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!
LGTM.

@anirudh2290 anirudh2290 merged commit 30b1cbc into apache:master Mar 8, 2019
@anirudhacharya anirudhacharya deleted the shape branch March 8, 2019 04:01
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault on ndarray with negative dimension i.e. mxnet.nx.zeros((-1,))
3 participants