This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
support leading dimension of -1 in ravel/unravel #14356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done from my side. |
marcoabreu
approved these changes
Mar 7, 2019
|
@mxnet-label-bot add [Operator, pr-awaiting-review] @asmushetzel Please add "Fixes #13862" in the PR description to automatically close the issue when this PR is merged |
|
Added the "Fixes #13862" in the PR description |
|
@apeforest @samskalicky @anirudh2290 for review |
samskalicky
approved these changes
Mar 8, 2019
wkcn
added
pr-awaiting-merge
|
The PR has been merged. |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13862
Using "-1" for the leading shape dimension was not officially documented but happened to work in versions 1.3.1 or lower as mshadow::index_t was unsigned so -1 was eventually interpreted as maxint. In subsequent versions of mxnet, mshadow::index_t has been changed to a signed type such that using -1 as leading shape dimension did not work anymore.
This fix documents that -1 is an allowed value for the leading dimension and re-enable behaviour of version 1.3.1. Note that it is natural to assume that this use case is supported as the value of the leading dimension of the shape is not needed for ravel/unravel computations anyway. Also it seems from above issue, that there are valid customer use cases that need support for this.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.