This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Bypass ThreadedEngine in test_convolution_multiple_streams. #14338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per discussion with @szha, this PR stabilizes the CI by eliminating errors in test_operator_gpu.py:test_convolution_multiple_streams that began with the merging of the subsequent PR #14223. The segfaults and python double-free aborts currently seen in this test only appear when run with MXNET_ENGINE_TYPE=ThreadedEngine (which uses the ThreadedEnginePooled class). It is hoped that @arcadiaphy will submit a follow-up PR to enable his improvements to run under the ThreadedEngine.
The test being modified was introduced by #14006.
This a the first step to resolving #14329.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments