This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Relaxing type requirements for reshape_like op #14325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
@mxnet-label-bot add [Operator, pr-awaiting-review] |
|
@ChaiBapchya @zhreshold for review |
ChaiBapchya
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
LGTM! Thanks! Good to merge once it passes the CI
@mxnet-label-bot add [pr-awaiting-testing]
zhreshold
approved these changes
Mar 5, 2019
|
Please let me know ci goes green, I can merge right after. |
|
@mxnet-label-bot update [Operator, pr-awaiting-merge] @zhreshold PR ready for merge |
marcoabreu
added
pr-awaiting-merge
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Relax type requirements in reshape_like * Add test * Fix lint * Retrigger CI
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Relax type requirements in reshape_like * Add test * Fix lint * Retrigger CI
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Relax type requirements in reshape_like * Add test * Fix lint * Retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly to #14097, reshape_like op should also not dictate the type of its second argument (since only shape metadata is used there).
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.