This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[clojure-package] add ->nd-vec function in ndarray.clj
#14308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-work-in-progress, Clojure] |
6 tasks
|
I would love some feedback on this @kedarbellare @gigasquid :-) |
|
taking a look 👀 |
gigasquid
reviewed
Mar 8, 2019
| (if-not (seq ss) | ||
| (vec v) | ||
| (->> v | ||
| (partition (/ (count v) s1)) |
There was a problem hiding this comment.
You will need to use clojure.core// instead of just / because the ndarray has a definition for the operator in this namespace
| [org.apache.clojure-mxnet.context :as mx-context] | ||
| [org.apache.clojure-mxnet.shape :as mx-shape] | ||
| [org.apache.clojure-mxnet.util :as util] | ||
| [clojure.reflect :as r] |
There was a problem hiding this comment.
Do you mind cleaning up `[clojure.reflect ] while you are in here? It should be removed.
| Ex: | ||
| (->nd-vec (array [1] [1 1 1])) ;[[[1.0]]] | ||
| (->nd-vec (ndarray/array [1 2 3] [3 1 1])) ;[[[1.0]] [[2.0]] [[3.0]]]" | ||
| [ndarray] |
There was a problem hiding this comment.
I like the function spec, do you think it would also be nice to be able to do a util/validate in here to check that it is a NDArray? when called without instrumentation?
kedarbellare
reviewed
Mar 9, 2019
kedarbellare
reviewed
Mar 9, 2019
| (s/def ::ndarray #(instance? NDArray %)) | ||
| (s/def ::vector vector?) | ||
| (s/def ::shape-vec-match-vec | ||
| (fn [[v vec-shape]] (= (count v) (reduce * 1 vec-shape)))) |
* WIP * Unit tests need to be added
|
Unit tests added and all checks have passed! |
gigasquid
changed the title
->nd-vec function in ndarray.clj->nd-vec function in ndarray.clj
|
Thanks for your contribution @Chouffe 😸 |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
…he#14308) * [clojure-package][wip] add `->nd-vec` function in `ndarray.clj` * WIP * Unit tests need to be added * [clojure-package][ndarray] add unit tests for `->nd-vec` util fn
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* [clojure-package][wip] add `->nd-vec` function in `ndarray.clj` * WIP * Unit tests need to be added * [clojure-package][ndarray] add unit tests for `->nd-vec` util fn
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…he#14308) * [clojure-package][wip] add `->nd-vec` function in `ndarray.clj` * WIP * Unit tests need to be added * [clojure-package][ndarray] add unit tests for `->nd-vec` util fn
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposal for adding a
->nd-vecfunction inndarray.cljChecklist
Essentials
Please feel free to remove inapplicable items for your PR.