This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [pr-awaiting-review] @ZhennanQin could you please rebase your PR and resolve the conflicts? |
reminisce
reviewed
Mar 4, 2019
anirudh2290
reviewed
Mar 4, 2019
anirudh2290
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZhennanQin . Nice work! Added minor comments, otherwise LGTM.
@anirudh2290 thanks a lot for the review :) @reminisce could you help to review again? |
reminisce
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on cosmetics. Otherwise LGTM.
pengzhao-intel
approved these changes
Mar 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
Will merge the PR after the CI pass.
perdasilva
pushed a commit
to perdasilva/incubator-mxnet
that referenced
this pull request
Mar 26, 2019
* Enhance PartitionGraph * Fix lint * Fix test * Run CI * Change subgraph property register * Change doc * Fix name * Run CI * Add env var in doc * Address comments. * run CI
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Enhance PartitionGraph * Fix lint * Fix test * Run CI * Change subgraph property register * Change doc * Fix name * Run CI * Add env var in doc * Address comments. * run CI
ZhennanQin
added a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
* Enhance PartitionGraph * Fix lint * Fix test * Run CI * Change subgraph property register * Change doc * Fix name * Run CI * Add env var in doc * Address comments. * run CI
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Enhance PartitionGraph * Fix lint * Fix test * Run CI * Change subgraph property register * Change doc * Fix name * Run CI * Add env var in doc * Address comments. * run CI
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Enhance PartitionGraph * Fix lint * Fix test * Run CI * Change subgraph property register * Change doc * Fix name * Run CI * Add env var in doc * Address comments. * run CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #14113. This PR covers:
inference_only
attr support whenSubgraphProperty
is created to indicate that this pass should be used for inference only.This PR is the full version of #14276.
@xinyu-intel @pengzhao-intel @TaoLv @reminisce @zheng-da
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments