Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1330] Bring nnvm::Tuple to mxnet::Tuple #14270

Merged
merged 9 commits into from
Mar 1, 2019

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Feb 27, 2019

Description

This PR is the initial part of efforts for the numpy module of MXNet #14253, in which we bring nnvm's Tuple and TShape into MXNet for all further changes to happen locally in MXNet. See the section "Changes" for details.

Test coverage is ensured automatically ensured by our CI pipeline, because this PR is checked by all testcases related to any NDArray's shape.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Bring nnvm::Tuple to mxnet::Tuple
  • Bring nnvm's passes into MXNet, including MXGradient, MXPlanMemory
  • Refactor the code a little bit by explicitly requiring "mxnet::" prefix, and using the alias "mxnet::ShapeVector" instead of "std::vector".

Comments

@junrushao junrushao changed the title Bring nnvm::Tuple to mxnet::Tuple [MXNET-1330] Bring nnvm::Tuple to mxnet::Tuple Feb 27, 2019
@reminisce reminisce added this to To do in numpy Feb 27, 2019
@reminisce
Copy link
Contributor

Thanks for being willing to making so many micro-surgical changes scattered all over the places.

@reminisce reminisce moved this from To do to In progress in numpy Feb 27, 2019
@reminisce reminisce moved this from In progress to Needs review in numpy Feb 27, 2019
include/mxnet/tuple.h Outdated Show resolved Hide resolved
include/mxnet/tuple.h Show resolved Hide resolved
numpy automation moved this from Needs review to Reviewer approved Feb 28, 2019
@junrushao
Copy link
Member Author

Hi, the CI has passed. Could someone kindly review and merge this PR if you have time? @szha @zheng-da @reminisce @eric-haibin-lin

include/mxnet/base.h Outdated Show resolved Hide resolved
@reminisce reminisce merged commit 992c3c0 into apache:master Mar 1, 2019
numpy automation moved this from Reviewer approved to Done Mar 1, 2019
@ptrendx ptrendx mentioned this pull request Mar 1, 2019
6 tasks
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Bring nnvm::Tuple to mxnet::Tuple

* Retrigger CI

* Fix issues casued by rebase

* Address comments from Jun

* Trigger CI

* Address comments from Da

* Retrigger due to flakiness

* Retrigger CI
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Bring nnvm::Tuple to mxnet::Tuple

* Retrigger CI

* Fix issues casued by rebase

* Address comments from Jun

* Trigger CI

* Address comments from Da

* Retrigger due to flakiness

* Retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants