Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Large array support for randint #14242

Merged
merged 3 commits into from
Mar 2, 2019

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Feb 23, 2019

Title
2 unit-tests

  1. checks if the shape of the array is indeed large enough
  2. checks if the randint value is indeed large

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
LGTM : )

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 27, 2019
@wkcn
Copy link
Member

wkcn commented Mar 1, 2019

Could you please retrigger the CI? Thanks!

@eric-haibin-lin eric-haibin-lin merged commit fb4f9d5 into apache:master Mar 2, 2019
@eric-haibin-lin
Copy link
Member

Thanks. Merged

@ChaiBapchya ChaiBapchya deleted the fix_large_array_randint branch March 7, 2019 04:51
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* large array support for randint

* with seed for 2 random large array tests

* Trigger notification
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* large array support for randint

* with seed for 2 random large array tests

* Trigger notification
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants