This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fixes #14181, validate model output shape for ObjectDetector. #14215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add[Scala, pr-awaiting-review] |
zachgk
reviewed
Feb 21, 2019
| @@ -66,6 +66,10 @@ class ImageClassifier(modelPathPrefix: String, | |||
| protected[infer] val height = inputShape(inputLayout.indexOf('H')) | |||
| protected[infer] val width = inputShape(inputLayout.indexOf('W')) | |||
|
|
|||
| def outputShapes: IndexedSeq[(String, Shape)] = { | |||
There was a problem hiding this comment.
The curly braces are not needed. You can just write def outputShapes: IndexedSeq[(String, Shape)] = predictor.outputShapes. Same for predictor.scala as well
lanking520
approved these changes
Feb 22, 2019
zachgk
approved these changes
Feb 25, 2019
|
@frankfliu Please do a pull-rebase on master to avoid Windows CI |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14181
Make sure model passed to ObjectDetector supports object detection and output bounding box.
Testing:
Executed attached testing code, InvalidArgumentException with proper message is thrown.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.