Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MXNet Java bug fixes and experience improvement #14213

Merged
merged 3 commits into from
Feb 28, 2019

Conversation

lanking520
Copy link
Member

Description

Add visualization method to Java users and source code fetching in demo section
@zachgk @piyushghai @andrewfayres @yzhliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 added the Java Label to identify Java API component label Feb 20, 2019
<groupId>org.apache.mxnet</groupId>
<artifactId>mxnet-full_${mxnet.scalaprofile}-${mxnet.profile}</artifactId>
<version>${mxnet.version}</version>
<classifier>sources</classifier>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attaching the sources jar

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for the Readme.

scala-package/mxnet-demo/java-demo/README.md Show resolved Hide resolved
scala-package/mxnet-demo/java-demo/README.md Outdated Show resolved Hide resolved
scala-package/mxnet-demo/java-demo/README.md Outdated Show resolved Hide resolved
scala-package/mxnet-demo/java-demo/bin/java_sample.sh Outdated Show resolved Hide resolved
@lanking520
Copy link
Member Author

@aaronmarkham Please review it again

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good.

@aaronmarkham aaronmarkham merged commit c319ae5 into apache:master Feb 28, 2019
@lanking520 lanking520 deleted the addJava branch March 11, 2019 22:28
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* improve Java user experience

* add the new examples

* fixed based on the comments
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 26, 2019
* improve Java user experience

* add the new examples

* fixed based on the comments
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 26, 2019
* improve Java user experience

* add the new examples

* fixed based on the comments
zachgk pushed a commit to zachgk/incubator-mxnet that referenced this pull request May 16, 2019
* improve Java user experience

* add the new examples

* fixed based on the comments
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* improve Java user experience

* add the new examples

* fixed based on the comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Java Label to identify Java API component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants