Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1299] Perl: sync with Python API #14194

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

sergeykolychev
Copy link
Contributor

@sergeykolychev sergeykolychev commented Feb 18, 2019

Description

Two more gluon loss classes.
Visualization fixes.
Gluon RNN rework, including hybridization.
Exposed GPU memory info to perl level.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Two more gluon loss classes.
Visualization fixes.
Gluon RNN rework, including hybridization.
Exposed GPU memory info to perl level.

Comments

Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
@sergeykolychev
Copy link
Contributor Author

@tlby Please check when you have time.

@roywei
Copy link
Member

roywei commented Feb 19, 2019

@mxnet-label-bot add[Perl, pr-awaiting-review]

@marcoabreu marcoabreu added Perl pr-awaiting-review PR is waiting for code review labels Feb 19, 2019
Copy link
Contributor

@tlby tlby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything suspicious, nice work.

@sergeykolychev sergeykolychev removed the pr-awaiting-review PR is waiting for code review label Feb 21, 2019
@sergeykolychev sergeykolychev merged commit 2347017 into apache:master Feb 21, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Visualization fixes.
Gluon rnn rework, including hybridization.
Exposed GPU memory info to perl level.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants