Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1325] Make InferShapeAttr a standalone pass #14193

Merged
merged 4 commits into from
Feb 26, 2019

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Feb 18, 2019

Description

Given the fact that there is going on work tweaking InferShape a lot, we have to separate the InferShapeAttr pass out.

This is part of effort to make dynamic shape executors.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add InferShapeAttr pass.

@junrushao junrushao changed the title Make InferShapeAttr a standalone pass [MXNET-1325] Make InferShapeAttr a standalone pass Feb 18, 2019
@junrushao
Copy link
Member Author

@szha @zheng-da Could you help review? Thanks a lot!

@roywei
Copy link
Member

roywei commented Feb 19, 2019

@mxnet-label-bot add[Backend, pr-awaiting-review]

@marcoabreu marcoabreu added Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review labels Feb 19, 2019
@szha szha merged commit 0af40f7 into apache:master Feb 26, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
* Make InferShapeAttr a standalone pass

* Fix

* Fix

* Fix
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
* Make InferShapeAttr a standalone pass

* Fix

* Fix

* Fix
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
* Make InferShapeAttr a standalone pass

* Fix

* Fix

* Fix
@ptrendx ptrendx mentioned this pull request Mar 1, 2019
6 tasks
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
* Make InferShapeAttr a standalone pass

* Fix

* Fix

* Fix
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Make InferShapeAttr a standalone pass

* Fix

* Fix

* Fix
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Make InferShapeAttr a standalone pass

* Fix

* Fix

* Fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backend Issues related to the backend of MXNet pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants