Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1323] CPP GPU test running too long #14149

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

leleamol
Copy link
Contributor

@leleamol leleamol commented Feb 13, 2019

Description

CPP GPU test running too long. The examples in ci_test.sh are taking longer time to finish. Reduced the number of epochs for which examples were running. Updated mlp example to accept the number of epochs to run. By default the example was running for 15000 epochs.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Note that the change is made to reduce the time to run the examples in ci_tests.sh.

@leleamol
Copy link
Contributor Author

@marcoabreu @lanking520
I have created this PR to shorten the time it takes to run the ci_tests.sh.
But the sanity check is failing. It doesn't seem to be related to my change. Can you please take a look?

@lanking520 lanking520 requested review from lanking520 and nswamy and removed request for nswamy February 13, 2019 23:46
@lanking520
Copy link
Member

Awesome, could you also put the issue link to it?

@lanking520
Copy link
Member

Could you please rebase with master, it seemed there is a rat license problem

@szha
Copy link
Member

szha commented Feb 13, 2019

@lanking520 master is broken right now

…hs in ci_test.sh to shorten the CI build time
@leleamol
Copy link
Contributor Author

#13924

@leleamol
Copy link
Contributor Author

@lanking520
The runtime for ci_test has reduced to ~25 mins. It still runs all the tests correctly.

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your optimization

@lanking520 lanking520 merged commit 518cd40 into apache:master Feb 14, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@leleamol leleamol deleted the faster_cpp_test branch June 10, 2019 18:12
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants