This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
make rat-excludes compliant with apache release policy #14142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the Markdown files currently not in compliance |
szha
requested review from
gigasquid,
iblislin,
nswamy,
sergeykolychev and
yzhliu
as code owners
|
Markdown license headers have been added. |
iblislin
approved these changes
Feb 13, 2019
szha
force-pushed
the
rat_comp
branch
2 times, most recently
from
08ca68c
to
5bf551a
Compare
gigasquid
approved these changes
Feb 13, 2019
|
@szha Thanks for your contribution! |
|
API docs are breaking: |
|
@szha as I said on the dev list, adding license headers to the markdown isn't required and might break the website. You also had that comment from Justin that referred to the same policy. I realize you're getting mixed signals on the general list. The policy clearly states we don't need to add licenses for information files and for the website. If you check your preview, you'll see that the site is broken. |
|
@aaronmarkham adding license header is required. I'm happy to submit patch to fix the website but we should not take a backward step. |
|
The Beam project seems to embed the licenses in their markdown files. Maybe we can do the same thing? |
|
Oh I see this PR has the license embedded in the same way as the Beam project. They are using https://github.com/apache/beam/tree/master/website Jekyll though for generation. |
|
It might have been caused by unpaired number of dashes in the comment. I'm verifying this assumption in the PR above. |
szha
added a commit
to szha/mxnet
that referenced
this pull request
Feb 14, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
szha
added a commit
to szha/mxnet
that referenced
this pull request
Feb 14, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
szha
added a commit
that referenced
this pull request
Feb 14, 2019
* make rat-excludes compliant with apache release policy (#14142) * remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist * fix website build (#14148) * fix rendering of markdown doc * fix missing license from lipnet example * fix diff
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
lanking520
pushed a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Feb 18, 2019
* make rat-excludes compliant with apache release policy (apache#14142) * remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist * fix website build (apache#14148) * fix rendering of markdown doc * fix missing license from lipnet example * fix diff
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 19, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* remove md from whitelist * remove rst from whitelist * remove docker folder from whitelist * remove docs from whitelist
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make rat-excludes compliant with apache release policy
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments