Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Doc Fix: added note about cuda9.2 requirement to Java example #14140

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

samskalicky
Copy link
Contributor

Description

example requires CUDA 9.2 but this wasnt mentioned anywhere in the instructions

Changes

Added note to clarify the CUDA 9.2 requirement

@@ -9,6 +9,8 @@ This command will pick the default values specified in the [pom](https://github.

Note: If you are planning to use GPU, please add `-Dmxnet.profile=linux-x86_64-gpu`

Note: The Maven package is built with CUDA 9.2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam for bringing this up.
I think this is the correct location for this disclaimer : https://github.com/apache/incubator-mxnet/tree/master/scala-package#pre-built-maven-packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... I never looked at this page before. Maybe we should add a link and generalize the note more and say something like "Make sure you're environment is configured correctly according to..." and link to that page then?

Users following this demo arent necessarily going to read all the docs before running. We need to keep things self-containted and succinct.

Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the note to the scala-demo as well since we try to keep them in sync?

@ankkhedia
Copy link
Contributor

@samskalicky Thanks for your contribution!

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Feb 13, 2019
@anirudhacharya
Copy link
Member

@zachgk will the coverage results get uploaded to the codecov report that is generated for all of mxnet on CI runs?

@karan6181
Copy link
Contributor

@samskalicky Can you please address the review comments ? Thanks!

@abhinavs95
Copy link
Contributor

abhinavs95 commented Mar 29, 2019

@samskalicky Ping for update!
@mxnet-label-bot update [pr-awaiting-response]

@marcoabreu marcoabreu added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Mar 29, 2019
@piyushghai
Copy link
Contributor

@lanking520 @samskalicky @zachgk Can we take this PR to completion ?

@lanking520 lanking520 merged commit 43f7c12 into apache:master Apr 4, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants