Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

follow up on fix nightly test #14134

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Conversation

roywei
Copy link
Member

@roywei roywei commented Feb 12, 2019

Description

This is a followup on #14119
fixes #14026

In addition of increase shared memory on docker, I reduced the number of workers. It was using 32 workers and created too large shared memory.

Thanks for the help from the Berlin team, I just attended the office hours and was able to reproduce the docker environment and test the fix.
This fix is tested and passed on CI docker using AWS Ubuntu DeepLearning Base AMI on g3.8xlarge
running following test passed:

ci/build.py --docker-registry mxnetci --nvidiadocker --platform ubuntu_nightly_gpu --docker-build-retries 3 --shm-size 1500m /work/runtime_functions.sh nightly_tutorial_test_ubuntu_python2_gpu

output:

----------------------------------------------------------------------
Ran 47 tests in 2199.521s

OK
build.py: 2019-02-12 19:42:10,706Z INFO Waiting for status of container a41697b9f1f0 for 600 s.
build.py: 2019-02-12 19:42:10,877Z INFO Container exit status: {'StatusCode': 0, 'Error': None}
build.py: 2019-02-12 19:42:10,878Z INFO Container exited with success 👍
build.py: 2019-02-12 19:42:10,878Z INFO Stopping container: a41697b9f1f0
build.py: 2019-02-12 19:42:10,879Z INFO Removing container: a41697b9f1f0

python 3 test also passed

ci/build.py --docker-registry mxnetci --nvidiadocker --platform ubuntu_nightly_gpu --docker-build-retries 3 --shm-size 1500m /work/runtime_functions.sh nightly_tutorial_test_ubuntu_python3_gpu

output:

----------------------------------------------------------------------
Ran 47 tests in 2243.615s

OK
build.py: 2019-02-12 22:45:02,862Z INFO Waiting for status of container b7cdfdae69c3 for 600 s.
build.py: 2019-02-12 22:45:03,055Z INFO Container exit status: {'Error': None, 'StatusCode': 0}
build.py: 2019-02-12 22:45:03,055Z INFO Container exited with success 👍
build.py: 2019-02-12 22:45:03,055Z INFO Stopping container: b7cdfdae69c3
build.py: 2019-02-12 22:45:03,057Z INFO Removing container: b7cdfdae69c3

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@roywei roywei requested a review from szha as a code owner February 12, 2019 20:01
@roywei
Copy link
Member Author

roywei commented Feb 12, 2019

@vishaalkapoor @marcoabreu could you help take a look? thanks!

@ankkhedia
Copy link
Contributor

ankkhedia commented Feb 12, 2019

@roywei Thanks for your contribution!

@mxnet-label-bot add [pr-awaiting-review, test]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Test labels Feb 12, 2019
@vishaalkapoor
Copy link
Contributor

Nice work. Thanks for getting to the root cause :)

LGTM!

Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit c704f1f into apache:master Feb 13, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nightly Test Failure] Tutorial test_tutorials.test_gluon_end_to_end Test Failure
6 participants