Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixes libjpeg-turbo dependecy under Ubuntu 16.04 #14127

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Feb 12, 2019

Description

Currently we cannot build mxnet on ubuntu 16.04 with USE_LIBJPEG_TURBO=1 because the library was compiled without PIC in the libturbo-jpeg library. Another package libjpegturbo fixes this issue.
see this.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Adds libjpeg-turbo dependency to ubuntu based builds appropriately.
Adds libjpeg-turbo flag to ubuntu builds. This is inline with the build flags used in the shipped version of mxnet, for instance, see this.

Now the CI and CD will be slightly more congruent.

@perdasilva perdasilva force-pushed the libjpegturbo branch 5 times, most recently from bb99ce2 to c6fc986 Compare February 12, 2019 18:07
@ankkhedia
Copy link
Contributor

ankkhedia commented Feb 12, 2019

@perdasilva Thanks for your contribution!

@mxnet-label-bot add [ pr-work-in-progress, build ]

@marcoabreu marcoabreu added Build pr-work-in-progress PR is still work in progress labels Feb 12, 2019
@perdasilva perdasilva changed the title [WIP] Fixes libjpeg-turbo dependecy under Ubuntu 16.04 Fixes libjpeg-turbo dependecy under Ubuntu 16.04 Feb 13, 2019
@perdasilva
Copy link
Contributor Author

perdasilva commented Feb 13, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Feb 13, 2019
@perdasilva
Copy link
Contributor Author

@mxnet-label-bot remove [pr-work-in-progress]

@marcoabreu marcoabreu removed the pr-work-in-progress PR is still work in progress label Feb 13, 2019
@marcoabreu
Copy link
Contributor

Should we maybe only turn it on for a few builds to increase the diversity?

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But makes sense to turn it on only for certain builds. Curious to know what's the compelling need for all of them?

@perdasilva
Copy link
Contributor Author

perdasilva commented Feb 14, 2019

I'm happy to have it only for certain ones. Do you guys have any suggestions based on your experience?
Still, I would just like to have as much parity as possible between what we test and what we ship.
Currently, LIB_JPEG_TURBO is enabled for the pip builds:

grep -r "TURBO" make/pip
make/pip/pip_linux_cpu.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu90.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu91.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu90mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu80mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu80.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu75mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu92.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu100.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_darwin_mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu100mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_darwin_cpu.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu91mkl.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu75.mk:USE_LIBJPEG_TURBO = 1
make/pip/pip_linux_cu92mkl.mk:USE_LIBJPEG_TURBO = 1

@marcoabreu marcoabreu merged commit cf46ca4 into apache:master Feb 14, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* Fixes libjepgturbo dependency install on ubuntu

* Enables libjpeg turbo on cpu build for testing
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
* Fixes libjepgturbo dependency install on ubuntu

* Enables libjpeg turbo on cpu build for testing
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
* Fixes libjepgturbo dependency install on ubuntu

* Enables libjpeg turbo on cpu build for testing
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Fixes libjepgturbo dependency install on ubuntu

* Enables libjpeg turbo on cpu build for testing
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Fixes libjepgturbo dependency install on ubuntu

* Enables libjpeg turbo on cpu build for testing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants