Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Added USE_SIGNAL_HANDLER to other Linux builds which didn't had it #14122

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Feb 11, 2019

Description

see title

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ankkhedia
Copy link
Contributor

@larroy Thanks for the contribution!
@mxnet-label-bot add [pr-awaiting-review, build]

@marcoabreu marcoabreu added Build pr-awaiting-review PR is waiting for code review labels Feb 12, 2019
@szha
Copy link
Member

szha commented Feb 12, 2019

@larroy rebase?

@larroy larroy force-pushed the signal_handler branch 2 times, most recently from 0f1ab85 to 4657de7 Compare February 13, 2019 23:14
@szha szha merged commit 059f49f into apache:master Feb 16, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@larroy larroy deleted the signal_handler branch February 18, 2019 13:36
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants