Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX export: Support equal length splits #14121

Merged
merged 3 commits into from
Feb 12, 2019
Merged

ONNX export: Support equal length splits #14121

merged 3 commits into from
Feb 12, 2019

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Feb 11, 2019 •
edited
Loading

Description

Fixes #13061

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Support for exporting and importing split operator when the split are of equal length

Comments

@vandanavk vandanavk requested a review from szha as a code owner February 11, 2019 21:53
@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review, ONNX]

@Roshrini for review

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Feb 11, 2019
@vandanavk vandanavk mentioned this pull request Feb 11, 2019
Closed
ChaiBapchya
ChaiBapchya suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good overall! Just to be sure, could we have a unit test to ensure the equal length split is correctly supported. I can see the changes in file test_cases but that isn't a unit test per se right?

@vandanavk
Copy link
Contributor Author

Thanks for reviewing @ChaiBapchya. The tests listed in test_cases.py are ONNX operator unit test cases . These test operator import/export. These are different from the operator test cases written in tests/python/unittest/test_operator.py of MXNet.

ChaiBapchya
ChaiBapchya approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Sweet! Thanks for clarifying. LGTM!

@Roshrini Roshrini merged commit ce031da into apache:master Feb 12, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@vandanavk @stephenrawls
ONNX export: Support equal length splits (apache#14121)
adc278c 
* ONNX export: Support equal length splits

* Fix lint error

* Add comment about checking for multiple outputs
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
@vandanavk
ONNX export: Support equal length splits (apache#14121)
fc09f37 
* ONNX export: Support equal length splits

* Fix lint error

* Add comment about checking for multiple outputs
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
@vandanavk @drivanov
ONNX export: Support equal length splits (apache#14121)
441cbc0 
* ONNX export: Support equal length splits

* Fix lint error

* Add comment about checking for multiple outputs
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@vandanavk @vdantu
ONNX export: Support equal length splits (apache#14121)
71e4f9d 
* ONNX export: Support equal length splits

* Fix lint error

* Add comment about checking for multiple outputs
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@vandanavk
ONNX export: Support equal length splits (apache#14121)
469f470 
* ONNX export: Support equal length splits

* Fix lint error

* Add comment about checking for multiple outputs
@QueensGambit QueensGambit mentioned this pull request Mar 13, 2020
Closed
7 tasks
@QueensGambit QueensGambit mentioned this pull request Jun 11, 2020
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roshrini Roshrini Roshrini approved these changes

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect ONNX export of SliceChannel
4 participants
@vandanavk @Roshrini @ChaiBapchya @marcoabreu