This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add dtype visualization to plot_network #14066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandanavk
reviewed
Feb 5, 2019
python/mxnet/visualization.py
Outdated
| shape_dict = dict(zip(interals.list_outputs(), out_shapes)) | ||
| shape_dict = dict(zip(internals.list_outputs(), out_shapes)) | ||
| draw_type = False | ||
| if dtype is not None: |
There was a problem hiding this comment.
nit: this seems slightly more readable.
draw_type = dtype is not None
if draw_type:
...
|
@mxnet-label-bot add [pr-awaiting-review, Visualization] |
szha
reviewed
Feb 13, 2019
| @@ -55,6 +56,7 @@ def test_plot_network(): | |||
| net = mx.sym.SoftmaxOutput(data=net, name='out') | |||
| with warnings.catch_warnings(record=True) as w: | |||
| digraph = mx.viz.plot_network(net, shape={'data': (100, 200)}, | |||
| dtype={'data': np.float32}, | |||
There was a problem hiding this comment.
should we be testing for dtypes other than np.float32?
There was a problem hiding this comment.
It does not really matter - this test just tries to catch errors during preparation of the picture, and for that the exact type used does not make any difference.
|
@szha Does anything else need to be done with this PR? |
|
Merged. Thanks for your contribution! |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Add dtype to plot_network * Added docstring for the new param * Added dtype to the plot_network test * Changes from review * Fixes from review * Fix typo * Retrigger CI
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Add dtype to plot_network * Added docstring for the new param * Added dtype to the plot_network test * Changes from review * Fixes from review * Fix typo * Retrigger CI
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Add dtype to plot_network * Added docstring for the new param * Added dtype to the plot_network test * Changes from review * Fixes from review * Fix typo * Retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add possibility to print type information alongside shape in
mx.vis.plot_network.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.