Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix website scala doc #14065

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Fix website scala doc #14065

merged 2 commits into from
Feb 5, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Feb 4, 2019

Description

Fix for Scala doc building on website for older versions

I tested this with ./build_all_version.sh "mxdoc;v1.3.x;v1.2.0;v1.1.0;v1.0.0;v0.12.0;v0.11.0" "mxdoc;1.3.1;1.2.1;1.1.0;1.0.0;0.12.1;0.11.0" https://github.com/zachgk/incubator-mxnet.git

@aaronmarkham @lanking520

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk requested a review from szha as a code owner February 4, 2019 23:04
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Scala, Doc]

@marcoabreu marcoabreu added Doc pr-awaiting-review PR is waiting for code review Scala labels Feb 4, 2019
@aaronmarkham aaronmarkham merged commit 8ba6402 into apache:master Feb 5, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* Fix doc building

* Remove deplicate in
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Fix doc building

* Remove deplicate in
@zachgk zachgk deleted the mxdoc branch April 12, 2019 22:24
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Fix doc building

* Remove deplicate in
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Doc pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants