This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix performance regression in normalize operator #14055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep-krishnamurthy
force-pushed
the
fix_normalize_perf
branch
from
46d1fa7
to
822d806
Compare
zhreshold
approved these changes
Feb 4, 2019
sandeep-krishnamurthy
force-pushed
the
fix_normalize_perf
branch
from
822d806
to
b590d41
Compare
vandanavk
approved these changes
Feb 4, 2019
|
@mxnet-label-bot add [pr-awaiting-review, Operator] |
sandeep-krishnamurthy
force-pushed
the
fix_normalize_perf
branch
from
b590d41
to
3b6164f
Compare
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* parallelize on channel forward pass * parallelize on channel normalize backward pass * Fix lint issues * Trying to fix CI build failure on GPU * Fix failing GPU test on CI Do not pass normalize param as is to GPU kernel * Fix to_tensor tests * Pass mean and std_dev as native types for kernel * Fix CI failure. Do not pass mean, std as vector to kernel
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* parallelize on channel forward pass * parallelize on channel normalize backward pass * Fix lint issues * Trying to fix CI build failure on GPU * Fix failing GPU test on CI Do not pass normalize param as is to GPU kernel * Fix to_tensor tests * Pass mean and std_dev as native types for kernel * Fix CI failure. Do not pass mean, std as vector to kernel
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* parallelize on channel forward pass * parallelize on channel normalize backward pass * Fix lint issues * Trying to fix CI build failure on GPU * Fix failing GPU test on CI Do not pass normalize param as is to GPU kernel * Fix to_tensor tests * Pass mean and std_dev as native types for kernel * Fix CI failure. Do not pass mean, std as vector to kernel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before regressing PR #13802
Total time for 50000 images of shape (3,300,300) to do normalization - 67.39s
Total time for 100000 images of shape (3,300,300) to do normalization - 134.72s
After regressing PR #13802
Total time for 50000 images of shape (3,300,300) to do normalization - 104.09s
Total time for 100000 images of shape (3,300,300) to do normalization - 203.78s
With changes in this PR
Total time for 50000 images of shape (3,300,300) to do normalization - 68.54s
Total time for 100000 images of shape (3,300,300) to do normalization - 136.12s
NOTE I have a revert PR #14054 , just in case, this PR gets delayed to be merged.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
@nswamy @zhreshold @stu1130