Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add new cloud providers to install page #14039

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

aaronmarkham
Copy link
Contributor

@aaronmarkham aaronmarkham commented Jan 31, 2019

Description

This PR adds several new cloud options.
Fixes #13713

Preview

http:https://34.201.8.176/versions/cloud_options/install/index.html?platform=Cloud&language=Python&processor=GPU
http:https://34.201.8.176/versions/cloud_options/install/index.html?platform=Cloud&language=Python&processor=CPU

Comments

As is typical with this install page, the selector doesn't work as expected. I tried to set GPU as the default button, but it still has CPU as default. 🤷‍♂️ Just tack this on to #13430.

@ptrendx
Copy link
Member

ptrendx commented Feb 1, 2019

The link to MXNet docker container should be https://ngc.nvidia.com/catalog/containers/nvidia:mxnet instead of https://ngc.nvidia.com/catalog/containers/nvidia%2Fmxnet

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChaiBapchya
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Feb 5, 2019
@aaronmarkham
Copy link
Contributor Author

@aaronmarkham aaronmarkham merged commit 78870c0 into apache:master Feb 5, 2019
@szha
Copy link
Member

szha commented Feb 5, 2019

@aaronmarkham actually the row spacing looks weird to me. Here's a screenshot.
image

@szha
Copy link
Member

szha commented Feb 5, 2019

I'm using Chrome 71.0.3578.98 on OSX 10.13.6.

@aaronmarkham
Copy link
Contributor Author

That's the CSS for bullets in this theme. Not really to do with the markdown. I don't really like it either.

stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* add new cloud providers

* fix colon
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* add new cloud providers

* fix colon
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* add new cloud providers

* fix colon
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants