Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix nightly test on tutorials #14036

Merged
merged 3 commits into from
Feb 4, 2019
Merged

fix nightly test on tutorials #14036

merged 3 commits into from
Feb 4, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented Jan 31, 2019

Description

fix #14026

  1. add scipy dependency
  2. change trainning epochs to 1 to avoid test timeout

1&2 shoud fix #14026

made additional follow ups on the tutorials:
3. added tutorials to index
4. change tutorial links to use website link instead of github md file links
5. removed unecessary bash
6. removed bold effect in table which is not rendering correctly in hybrid tutorial

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@roywei roywei requested a review from szha as a code owner January 31, 2019 17:19
@roywei
Copy link
Member Author

roywei commented Jan 31, 2019

@Chancebair @ThomasDelteil could you take a look? thanks!

@Roshrini Roshrini merged commit 9de7e5a into apache:master Feb 4, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* fix nightly test

* fix typo

* trigger ci
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* fix nightly test

* fix typo

* trigger ci
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* fix nightly test

* fix typo

* trigger ci
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nightly Test Failure] Tutorial test_tutorials.test_gluon_end_to_end Test Failure
4 participants