Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update the scala installation tutorial on intellij #14033

Merged
merged 3 commits into from
Feb 4, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Jan 31, 2019

Description

Fix the scala installation doc

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@zachgk @lanking520 @piyushghai @andrewfayres @frankfliu

Comments

@stu1130 stu1130 requested a review from szha as a code owner January 31, 2019 01:21
@@ -324,7 +325,7 @@ log4j.appender.stdout.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss,SSS} [%t]

**Step 6.** Build the project:
- To build the project, from the menu choose Build, and then choose Build Project.

* Note that if you run into ```bad option: '-make:transitive'```, please follow the [how to solve scalac-error-bad-option-maketransitive](https://stackoverflow.com/questions/35016945/scalac-error-bad-option-maketransitive-on-mvn-package-via-command-line)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change from the stackoverflow page did you apply to solve the error? Can you either apply it directly to the POM in Step 3 so users following the tutorial don't have to worry about it or copy the solution you found directly into the tutorial?

@stu1130
Copy link
Contributor Author

stu1130 commented Feb 4, 2019

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 4, 2019
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making these changes :)

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronmarkham aaronmarkham merged commit 9aba77b into apache:master Feb 4, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
* update the scala installation tutorial on intellij

* update the so answer

* update the so answer
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* update the scala installation tutorial on intellij

* update the so answer

* update the so answer
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* update the scala installation tutorial on intellij

* update the so answer

* update the so answer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants