Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[R] Add NAG optimizer #14023

Merged
merged 1 commit into from
Feb 1, 2019
Merged

[R] Add NAG optimizer #14023

merged 1 commit into from
Feb 1, 2019

Conversation

anirudhacharya
Copy link
Member

@anirudhacharya anirudhacharya commented Jan 30, 2019

Description

Nesterov accelerated SGD for R API.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • nag opt
  • tests for nag opt

Comments

Copy link
Contributor

@hetong007 hetong007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for bringing it into R. Will merge it tomorrow if no further comment.

Note that for now NAG in MXNet is slower than SGD. So once we have something like mx.symbol.nag_update available, the implementation here needs to be updated.

@hetong007 hetong007 merged commit 439377d into apache:master Feb 1, 2019
stu1130 added a commit to stu1130/incubator-mxnet that referenced this pull request Feb 1, 2019
@anirudhacharya anirudhacharya deleted the nag_r branch February 8, 2019 22:37
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants