Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix jar path and add missing ones for spark jobs #14020

Merged
merged 4 commits into from
Feb 15, 2019
Merged

Fix jar path and add missing ones for spark jobs #14020

merged 4 commits into from
Feb 15, 2019

Conversation

ashutosh-dwivedi-e3502
Copy link
Contributor

@ashutosh-dwivedi-e3502 ashutosh-dwivedi-e3502 commented Jan 29, 2019 •
edited
Loading

Fix path of jars / add missing jars in spark job

remove print, reduce clutter

Description

Path of jar files in tests for MXNet on Spark are incorrect. This PR fixes it.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [] Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ashutosh-dwivedi-e3502
Fix jar path and add missing ones for spark jobs
e985917 
Fix path of jars / add missing jars in spark job

remove print, reduce clutter
@ashutosh-dwivedi-e3502 ashutosh-dwivedi-e3502 mentioned this pull request Jan 29, 2019
Open
ChaiBapchya
ChaiBapchya suggested changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I can see an issue created.
Can merge once the CI tests pass.
Just want the clarification on 1 comment.
Thanks for the contribution. 👍

scala-package/spark/src/test/scala/org/apache/mxnet/spark/SharedSparkContext.scala Show resolved Hide resolved
@vandanavk
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review, Scala]

@aashudwivedi could you re-trigger the CI?

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Scala labels Feb 4, 2019
@ashutosh-dwivedi-e3502
Copy link
Contributor Author

I've re-triggered the CI, all tests have passed now.
Thanks for having a look.

piyushghai
piyushghai approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me!
Thanks for fixing this and welcome to the MXNet community :)

@ashutosh-dwivedi-e3502
Copy link
Contributor Author

Looks okay to me!
Thanks for fixing this and welcome to the MXNet community :)
Thanks you :)

@ankkhedia
Copy link
Contributor

@lanking520 ping for review/merge.

lanking520
lanking520 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the Spark example

@lanking520 lanking520 merged commit 8416c56 into apache:master Feb 15, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@ashutosh-dwivedi-e3502 @stephenrawls
Fix jar path and add missing ones for spark jobs (apache#14020)
b3f69c8 
* Fix jar path and add missing ones for spark jobs

Fix path of jars / add missing jars in spark job

remove print, reduce clutter

* fixes scalastyle violations

* exclude all of javadoc, sources, bundle, and src while searching for jars

* simplfied the exclude experession
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
@ashutosh-dwivedi-e3502
Fix jar path and add missing ones for spark jobs (apache#14020)
a1d565c 
* Fix jar path and add missing ones for spark jobs

Fix path of jars / add missing jars in spark job

remove print, reduce clutter

* fixes scalastyle violations

* exclude all of javadoc, sources, bundle, and src while searching for jars

* simplfied the exclude experession
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
@ashutosh-dwivedi-e3502 @drivanov
Fix jar path and add missing ones for spark jobs (apache#14020)
6c0c96a 
* Fix jar path and add missing ones for spark jobs

Fix path of jars / add missing jars in spark job

remove print, reduce clutter

* fixes scalastyle violations

* exclude all of javadoc, sources, bundle, and src while searching for jars

* simplfied the exclude experession
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@ashutosh-dwivedi-e3502 @vdantu
Fix jar path and add missing ones for spark jobs (apache#14020)
ae63b4d 
* Fix jar path and add missing ones for spark jobs

Fix path of jars / add missing jars in spark job

remove print, reduce clutter

* fixes scalastyle violations

* exclude all of javadoc, sources, bundle, and src while searching for jars

* simplfied the exclude experession
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@ashutosh-dwivedi-e3502
Fix jar path and add missing ones for spark jobs (apache#14020)
9a315de 
* Fix jar path and add missing ones for spark jobs

Fix path of jars / add missing jars in spark job

remove print, reduce clutter

* fixes scalastyle violations

* exclude all of javadoc, sources, bundle, and src while searching for jars

* simplfied the exclude experession
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiBapchya ChaiBapchya ChaiBapchya requested changes

@zachgk zachgk zachgk approved these changes

@piyushghai piyushghai piyushghai approved these changes

@lanking520 lanking520 lanking520 approved these changes

@nswamy nswamy Awaiting requested review from nswamy nswamy is a code owner

@yzhliu yzhliu Awaiting requested review from yzhliu yzhliu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review Scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ashutosh-dwivedi-e3502 @vandanavk @ankkhedia @zachgk @piyushghai @ChaiBapchya @lanking520 @marcoabreu