This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-1315] Add checks for dynamic-shaped operators in CachedOp #14018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review, Operator] |
|
@szha Hi, just passed the CI. Could you help review this PR? |
|
@zheng-da Hi could you help review this PR? |
zheng-da
reviewed
Feb 11, 2019
| @@ -222,8 +222,12 @@ void LoopState::Forward(int iter_no, | |||
| // If an input and an output share the array, the output array will be changed | |||
| // by CachedOp. We need to copy data to the real output. | |||
| for (size_t i = 0; i < out_bufs.size(); i++) | |||
| if (!out_bufs[i].IsSame(coutputs[i])) | |||
| if (!out_bufs[i].IsSame(coutputs[i])) { | |||
There was a problem hiding this comment.
please add comments to explain this.
|
Should be good to merge once CI passes |
|
@zheng-da Finally get CI passed. Could you help merge this PR? Thanks! |
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
…che#14018) * Initial commit * Try this * Boy next door! * Add comments per discussion with Da * Try this * boy try this * change the boss of the gym
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 19, 2019
…che#14018) * Initial commit * Try this * Boy next door! * Add comments per discussion with Da * Try this * boy try this * change the boss of the gym
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
…che#14018) * Initial commit * Try this * Boy next door! * Add comments per discussion with Da * Try this * boy try this * change the boss of the gym
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
…che#14018) * Initial commit * Try this * Boy next door! * Add comments per discussion with Da * Try this * boy try this * change the boss of the gym
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…che#14018) * Initial commit * Try this * Boy next door! * Add comments per discussion with Da * Try this * boy try this * change the boss of the gym
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the effort that enables dynamic while loop. #13419
CC: @szha @zheng-da
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
is_dynamicinCachedOpfor upstream control flow operators to create a dynamic operators.Comments