Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove all usages of makefile for scala #14013

Merged
merged 4 commits into from
Feb 4, 2019
Merged

Remove all usages of makefile for scala #14013

merged 4 commits into from
Feb 4, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jan 28, 2019

Description

There were some remaining usages of the main makefile for scala which has been deprecated in favor of using maven directly. I removed all of the remaining ones.

@aaronmarkham @piyushghai @lanking520 @andrewfayres @gigasquid

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk requested a review from szha as a code owner January 28, 2019 23:18
lanking520
lanking520 approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

szha
szha reviewed Jan 29, 2019
View reviewed changes
docs/mxdoc.py Outdated Show resolved Hide resolved
@zachgk
Copy link
Contributor Author

zachgk commented Feb 4, 2019

Can I get anyone else to review this?

@piyushghai @andrewfayres

@szha szha merged commit 7ad4aca into apache:master Feb 4, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@zachgk @stephenrawls
Remove all usages of makefile for scala (apache#14013)
d3b43ac 
* Remove all usages of makefile for scala

* Unify making folders for scala/java setup

* Fix mxdoc path

* Add batch mode to calls
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@zachgk @vdantu
Remove all usages of makefile for scala (apache#14013)
71e6b3f 
* Remove all usages of makefile for scala

* Unify making folders for scala/java setup

* Fix mxdoc path

* Add batch mode to calls
@zachgk zachgk deleted the noMakeScala branch April 12, 2019 22:24
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@zachgk
Remove all usages of makefile for scala (apache#14013)
e460c9d 
* Remove all usages of makefile for scala

* Unify making folders for scala/java setup

* Fix mxdoc path

* Add batch mode to calls
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

@lanking520 lanking520 lanking520 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zachgk @szha @lanking520