Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Added optional parameters to BilinearResize2D to do relative scaling #13985

Merged
merged 3 commits into from
Jan 25, 2019

Conversation

ifeherva
Copy link
Contributor

@ifeherva ifeherva commented Jan 25, 2019

Description

This PR adds 2 additional optional parameters to the contrib.BilinearResize2D operator to do relative down/upsampling. This will help situations where the the required output size depends on the input size and input size is not available runtime (symbolic).
The change is fully backward-compatible.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@sandeep-krishnamurthy sandeep-krishnamurthy added Operator pr-awaiting-merge Review and CI is complete. Ready to Merge labels Jan 25, 2019
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM.

@stu1130 - FYI

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 577275d into apache:master Jan 25, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
…pache#13985)

* Added optional parameters to BilinearResize2D to do relative scaling

* Removed unnecessary params in unit tests.

* Fixed deprecated casting style
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
…pache#13985)

* Added optional parameters to BilinearResize2D to do relative scaling

* Removed unnecessary params in unit tests.

* Fixed deprecated casting style
@ifeherva ifeherva deleted the bilinear_resize_scale branch February 10, 2019 04:44
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
…pache#13985)

* Added optional parameters to BilinearResize2D to do relative scaling

* Removed unnecessary params in unit tests.

* Fixed deprecated casting style
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
…pache#13985)

* Added optional parameters to BilinearResize2D to do relative scaling

* Removed unnecessary params in unit tests.

* Fixed deprecated casting style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Operator pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants