Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX export: broadcast_to, tile ops #13981

Merged
merged 4 commits into from
Feb 5, 2019
Merged

ONNX export: broadcast_to, tile ops #13981

merged 4 commits into from
Feb 5, 2019

Conversation

Roshrini
Copy link
Member

@Roshrini Roshrini commented Jan 24, 2019 •
edited
Loading

Description

Exporting broadcast_to and tile operator
@vandanavk

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@Roshrini Roshrini requested a review from szha as a code owner January 24, 2019 18:14
@Roshrini Roshrini changed the title ONNX export: broadcast_to, tile ops [WIP]ONNX export: broadcast_to, tile ops Jan 24, 2019
@Roshrini Roshrini added ONNX pr-work-in-progress PR is still work in progress labels Jan 24, 2019
@Roshrini Roshrini changed the title [WIP]ONNX export: broadcast_to, tile ops ONNX export: broadcast_to, tile ops Jan 25, 2019
@Roshrini Roshrini added pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress labels Jan 25, 2019
@Roshrini Roshrini mentioned this pull request Jan 26, 2019
Merged
4 tasks
@Roshrini
Copy link
Member Author

Roshrini commented Feb 1, 2019

@zhreshold For review

@Roshrini Roshrini merged commit ae997eb into apache:master Feb 5, 2019
@Roshrini Roshrini deleted the tile-expand branch February 5, 2019 19:18
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@Roshrini @stephenrawls
ONNX export: broadcast_to, tile ops (apache#13981)
40b0b3c 
* Expand,tile op export

* fix

* adding test cases

* adding comments
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@Roshrini @vdantu
ONNX export: broadcast_to, tile ops (apache#13981)
ff1ccee 
* Expand,tile op export

* fix

* adding test cases

* adding comments
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@Roshrini
ONNX export: broadcast_to, tile ops (apache#13981)
e3a99ca 
* Expand,tile op export

* fix

* adding test cases

* adding comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vandanavk vandanavk vandanavk approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Roshrini @vandanavk