This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix website error pages #13963
Merged
Fix website error pages #13963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
reviewed
Jan 23, 2019
| </div> | ||
| <div> | ||
| <span id="page-does-not-exist"></span><h1>Page Does Not Exist</h1> | ||
| <p>If you’re here that means you requested a page that doesn’t exist. Sorry about that! Maybe try the search box to find what you’re looking for, or navigate to the <a href="https://mxnet.incubator.apache.org/index.html">Home Page</a>. Also, make sure you’re looking in the correct version, as some features may only be available in <a href="https://github.com/apache/incubator-mxnet/releases">newer versions</a> or the <a href="https://mxnet.incubator.apache.org/versions/master">master branch</a>.</p> |
There was a problem hiding this comment.
Yes, I fixed that. Thanks.
marcoabreu
approved these changes
Jan 23, 2019
aaronmarkham
force-pushed
the
fix_error_page_2
branch
from
fc91553
to
0b00237
Compare
aaronmarkham
force-pushed
the
fix_error_page_2
branch
from
0b00237
to
c39f4fd
Compare
jlcontreras
pushed a commit
to jlcontreras/incubator-mxnet
that referenced
this pull request
Feb 14, 2019
* fix error redirect * add error artifacts for local build
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* fix error redirect * add error artifacts for local build
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fix error redirect * add error artifacts for local build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13959
This PR creates new error pages, uses some better regex's in the
.htaccessfile, and it provides better artifact handling for the build process.Changes
ErrorDocumentfor 404 errors to a local file instead of using a hard-coded link to the error page in production. This is partly why we ended up with a redirect loop. It also had the drawback of giving a 302 redirect header instead of 404. Bots 🤖 don't like that, plus it was probably fooling the broken link checker.mxnet.cssartifact copy to the Sphinx script function to better consolidate artifact and build updates; also this help make sure that any updates to css in your dev version will get applied during a local build AND a full website publishPreview
Aside from the redirect test links, you can try:
🌮 Break things with a random URL like: http:https://34.201.8.176/versions/local_error/tacos
❓ Look for an API doc that doesn't exist, like Clojure for v0.11.0: http:https://34.201.8.176/versions/0.11.0/api/clojure/index.html
Note that I redirect 🌮 requests or anything really in an API subfolder's that is designated in the .htaccess file to the API error, rather than the 404 error. This way we can say, well, maybe it does exist, so try a different version.
Comments
Unfortunately, for some reason
ErrorDocumentconverts the environment variable fordefault_versionjust fine, but then just outputs the URL as text to the browser rather that forcing a redirect. So it has to stay hard-coded tomaster. (That's fine anyway as I can't imagine why an error page could be the latest at all times.)