Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

adding tolerance to flaky test #13850

Merged
merged 3 commits into from
Jan 14, 2019
Merged

adding tolerance to flaky test #13850

merged 3 commits into from
Jan 14, 2019

Conversation

Roshrini
Copy link
Member

Description

Fixes: #13839
@vandanavk

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@Roshrini
Copy link
Member Author

Roshrini commented Jan 11, 2019

@mxnet-label-bot Add [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Jan 11, 2019
@Roshrini
Copy link
Member Author

@larroy for review

@nswamy nswamy merged commit f554835 into apache:master Jan 14, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* adding tolerance

* retrigger ci

* retrigger ci
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky ONNX test TestNode.test_imports
4 participants