Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13848

Merged
merged 12 commits into from
Mar 7, 2019
Merged

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13848

merged 12 commits into from
Mar 7, 2019

Conversation

cchung100m
Copy link
Contributor

@cchung100m cchung100m commented Jan 11, 2019 •
edited
Loading

Description

solve pylint errors in examples with issue #12205

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cchung100m cchung100m requested a review from szha as a code owner January 11, 2019 15:01
@cchung100m cchung100m mentioned this pull request Jan 11, 2019
Open
@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@vandanavk for review

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 11, 2019
vandanavk
vandanavk reviewed Jan 14, 2019
View reviewed changes
Copy link
Contributor

@vandanavk vandanavk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. could you retrigger the CI

stu1130
stu1130 reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work @cchung100m
Welcome to MXNet community!
Don't forget to add your name in contribution list

example/cnn_chinese_text_classification/data_helpers.py Outdated Show resolved Hide resolved
example/cnn_text_classification/data_helpers.py Outdated Show resolved Hide resolved
example/cnn_text_classification/data_helpers.py Outdated Show resolved Hide resolved
example/cnn_text_classification/text_cnn.py Show resolved Hide resolved
example/autoencoder/model.py Outdated Show resolved Hide resolved
example/distributed_training/cifar10_dist.py Show resolved Hide resolved
stu1130
stu1130 approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest part LGTM

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Jan 27, 2019
@vandanavk
Copy link
Contributor

@sandeep-krishnamurthy for review/merge

@sandeep-krishnamurthy
Copy link
Contributor

LGTM. @cchung100m - Can you please pull rebase, there is a flaky test that was fixed couple of days ago in the master branch.

@cchung100m
Copy link
Contributor Author

Hi @sandeep-krishnamurthy

I complete the rebase and re-test on this branch, I will appreciate if you can help to review/merge, thanks.

@cchung100m
Copy link
Contributor Author

Hi @sandeep-krishnamurthy

Could you please help to review or merge, thanks :)

@Roshrini
Copy link
Member

Roshrini commented Mar 4, 2019

Hi @cchung100m Can you resolve one conflicting file then we can merge this PR? Thanks!

cchung100m
cchung100m commented Mar 5, 2019
View reviewed changes
Copy link
Contributor Author

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cchung100m and others added 10 commits March 5, 2019 18:36
@cchung100m
Copy link
Contributor Author

Hi @Roshrini

I reviewed the conflicting file and passed the CI, please help to merge this PR again, thanks. :)

@wkcn wkcn merged commit f4ab2d7 into apache:master Mar 7, 2019
@wkcn
Copy link
Member

wkcn commented Mar 7, 2019

@cchung100m
The PR has been merged. Thanks for your contribution!

vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@cchung100m @vdantu
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
dadad01 
…che#13848)

* [issue_12205 - PART1]

* [issue_12205 - PART2]

* Update example/cnn_chinese_text_classification/data_helpers.py

Co-Authored-By: cchung100m <[email protected]>

* Update example/distributed_training/cifar10_dist.py

Co-Authored-By: cchung100m <[email protected]>

* unify the style

unify the style

* unify the style

unify the style

* Update model.py

* unify the style here

unify the style here

* Remove the preposition 'with' in comment

Remove the preposition 'with' in comment 'Train module using Caffe operator in MXNet'

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* add CONTRIBUTORS.md

* retrigger the CI
nswamy pushed a commit that referenced this pull request Apr 5, 2019
@cchung100m @nswamy
[MXNET-1291] solve pylint errors in examples with issue no.12205 (#13848
43d87b0 
)

* [issue_12205 - PART1]

* [issue_12205 - PART2]

* Update example/cnn_chinese_text_classification/data_helpers.py

Co-Authored-By: cchung100m <[email protected]>

* Update example/distributed_training/cifar10_dist.py

Co-Authored-By: cchung100m <[email protected]>

* unify the style

unify the style

* unify the style

unify the style

* Update model.py

* unify the style here

unify the style here

* Remove the preposition 'with' in comment

Remove the preposition 'with' in comment 'Train module using Caffe operator in MXNet'

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* add CONTRIBUTORS.md

* retrigger the CI
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@cchung100m
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
7ca0a0b 
…che#13848)

* [issue_12205 - PART1]

* [issue_12205 - PART2]

* Update example/cnn_chinese_text_classification/data_helpers.py

Co-Authored-By: cchung100m <[email protected]>

* Update example/distributed_training/cifar10_dist.py

Co-Authored-By: cchung100m <[email protected]>

* unify the style

unify the style

* unify the style

unify the style

* Update model.py

* unify the style here

unify the style here

* Remove the preposition 'with' in comment

Remove the preposition 'with' in comment 'Train module using Caffe operator in MXNet'

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* add CONTRIBUTORS.md

* retrigger the CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stu1130 stu1130 stu1130 approved these changes

@Roshrini Roshrini Roshrini approved these changes

@vandanavk vandanavk vandanavk approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cchung100m @anirudhacharya @vandanavk @sandeep-krishnamurthy @Roshrini @wkcn @stu1130 @marcoabreu