This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add error checking for cpp examples. #13828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoLv
reviewed
Jan 10, 2019
cpp-package/example/mlp_cpu.cpp
Outdated
| @@ -63,10 +63,14 @@ int main(int argc, char** argv) { | |||
| }; | |||
|
|
|||
| auto train_iter = MXDataIter("MNISTIter"); | |||
| setDataIter(&train_iter, "Train", data_files, batch_size); | |||
| if (!setDataIter(&train_iter, "Train", data_files, batch_size)) { | |||
|
|
|||
| @@ -244,10 +244,14 @@ int main(int argc, char const *argv[]) { | |||
| }; | |||
|
|
|||
| auto train_iter = MXDataIter("MNISTIter"); | |||
| setDataIter(&train_iter, "Train", data_files, batch_size); | |||
| if (!setDataIter(&train_iter, "Train", data_files, batch_size)) { | |||
| return 1; | |||
There was a problem hiding this comment.
Can we have some descriptive error messages?
There was a problem hiding this comment.
The error message already printed in check_datafiles()
|
@mxnet-label-bot add [pr-awaiting-review] |
TaoLv
approved these changes
Jan 16, 2019
|
Restarted the test |
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In current cpp example, if data file isn't exist, example application will crash with sig 11 .
Add error checking to avoid crash.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.