Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

Merged
merged 6 commits into from
Feb 11, 2019
Merged

[MXNET-1291] solve pylint errors in examples with issue no.12205 #13815

merged 6 commits into from
Feb 11, 2019

Conversation

cchung100m
Copy link
Contributor

@cchung100m cchung100m commented Jan 9, 2019 •
edited
Loading

Description

solve pylint errors in examples with issue #12205

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cchung100m cchung100m requested a review from szha as a code owner January 9, 2019 14:52
@cchung100m cchung100m closed this Jan 9, 2019
@cchung100m
Copy link
Contributor Author

I will open PR after finishing all parts of commits

@cchung100m cchung100m changed the title [issue_12205 - PART1] solve pylint errors in examples with issue no.12205 [MXNET-1291] solve pylint errors in examples with issue no.12205 Jan 10, 2019
@cchung100m cchung100m reopened this Jan 10, 2019
@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@vandanavk for review

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jan 10, 2019
@cchung100m cchung100m mentioned this pull request Jan 11, 2019
Open
@vandanavk
Copy link
Contributor

the changes LGTM. could you fix the conflict - example/bayesian-methods/bdk_demo.py?

@cchung100m
Copy link
Contributor Author

cchung100m commented Jan 17, 2019 •
edited
Loading

@vandanavk

the changes LGTM. could you fix the conflict - example/bayesian-methods/bdk_demo.py?

I solve the conflict of bdk_demo.py and re-trigger the CI. thank you for the suggestions. :)

@vandanavk
Copy link
Contributor

@sandeep-krishnamurthy for review

@cchung100m
Copy link
Contributor Author

Hi @marcoabreu ,

Sorry for asking a rookie problem, how to re-trigger the failed job from Jenkins except commit another change of files.

Best regards,

@marcoabreu
Copy link
Contributor

marcoabreu commented Feb 1, 2019 via email

@cchung100m
Copy link
Contributor Author

@marcoabreu ,

Thanks for the prompt reply. You make me a great progress on participating open source community. (laugh) Thanks again.

Best regards,

@cchung100m
git pull the lastest code from master of incubator-mxnet
83c3489
@cchung100m
Unify the style here
ed91e2c 
Unify the style here and remove the testing 'print' code segment.
@cchung100m
Unify the description of comment
454aaca 
Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"
@cchung100m
Unify the style of comments
df9b905 
Unify the style of comments suggested by @sandeep-krishnamurthy
@cchung100m
Complete rebase
b928376
@cchung100m
Solve PEP8 [C0304 ] Final newline missing
d855aba 
Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing
@cchung100m
Copy link
Contributor Author

Hi @sandeep-krishnamurthy @marcoabreu

I complete the rebase and re-test, I will appreciate if you can help to review/merge, thanks.

sandeep-krishnamurthy
sandeep-krishnamurthy approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cchung100m for all your contributions!
LGTM
Can be merged after CI test passes.

@sandeep-krishnamurthy sandeep-krishnamurthy added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Feb 10, 2019
@cchung100m
Copy link
Contributor Author

Hi @sandeep-krishnamurthy

Thanks for the prompt reply, and CI test passes.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 0a2419f into apache:master Feb 11, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
@cchung100m @stephenrawls
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
96a9e74 
…che#13815)

* Unify the style here

Unify the style here and remove the testing 'print' code segment.

* Unify the description of comment

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* git pull the lastest code from master of incubator-mxnet

* Complete rebase

* Solve PEP8 [C0304 ] Final newline missing

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 19, 2019
@cchung100m
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
5282691 
…che#13815)

* Unify the style here

Unify the style here and remove the testing 'print' code segment.

* Unify the description of comment

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* git pull the lastest code from master of incubator-mxnet

* Complete rebase

* Solve PEP8 [C0304 ] Final newline missing

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
@cchung100m @drivanov
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
8ff7202 
…che#13815)

* Unify the style here

Unify the style here and remove the testing 'print' code segment.

* Unify the description of comment

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* git pull the lastest code from master of incubator-mxnet

* Complete rebase

* Solve PEP8 [C0304 ] Final newline missing

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@cchung100m @vdantu
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
6ecdc02 
…che#13815)

* Unify the style here

Unify the style here and remove the testing 'print' code segment.

* Unify the description of comment

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* git pull the lastest code from master of incubator-mxnet

* Complete rebase

* Solve PEP8 [C0304 ] Final newline missing

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@cchung100m
[MXNET-1291] solve pylint errors in examples with issue no.12205 (apa…
cd4fe58 
…che#13815)

* Unify the style here

Unify the style here and remove the testing 'print' code segment.

* Unify the description of comment

Change the description of comment from "multi-layer perceptron" to "Get multi-layer perceptron"

* Unify the style of comments

Unify the style of comments suggested by @sandeep-krishnamurthy

* git pull the lastest code from master of incubator-mxnet

* Complete rebase

* Solve PEP8 [C0304 ] Final newline missing

Sovle example/deep-embedded-clustering/solver.py(150): [C0304 ] Final newline missing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy approved these changes

@vandanavk vandanavk vandanavk approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cchung100m @anirudhacharya @vandanavk @marcoabreu @sandeep-krishnamurthy