Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update LICENSE File with subcomponents #13808

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jan 9, 2019

Description

This PR updates the main LICENSE file by adding missing subcomponents of the project, combining the BSD licenses to their own section, and removing several subcomponents that were deleted.

It updates the two whitelists for automatic license checks by removing files that should not be there (this may involve adding the appropriate headers to files). Explanations were also added for each element in the license_header.py whitelist. Lastly, automatic checking for clojure and pyx files was also enabled.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk
Copy link
Contributor Author

zachgk commented Jan 9, 2019

@mxnet-label-bot add [Licenses]

Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me.

@@ -1,3 +1,20 @@
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even think we use this file...

@ddavydenko
Copy link
Contributor

@frankfliu , could you please also take a look?

Copy link
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 merged commit 55ffe25 into apache:master Jan 10, 2019
zachgk added a commit to zachgk/incubator-mxnet that referenced this pull request Jan 11, 2019
* Update LICENSE File with subcomponents

* Fix JavaScript licenses
@lupesko
Copy link
Contributor

lupesko commented Jan 14, 2019

Great work @zachgk - thank you!

@lupesko
Copy link
Contributor

lupesko commented Jan 14, 2019

@zachgk should this be cherry picked into 1.4.x?

@aaronmarkham
Copy link
Contributor

We need the following to be sync'd up across master and 1.4.x:

@zachgk
Copy link
Contributor Author

zachgk commented Jan 14, 2019

@lupesko This should be cherry-picked and I added a PR for it at #13856.

@aaronmarkham

In summary, the only change still needed should be PR #13856

lanking520 pushed a commit that referenced this pull request Jan 16, 2019
* Update LICENSE File with subcomponents (#13808)

* Update LICENSE File with subcomponents

* Fix JavaScript licenses

* Add copyrights for third party licenses to license file (#13851)

* Remove R-package from LICENSE

* Update googletest due to licensing
lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Feb 18, 2019
* Update LICENSE File with subcomponents (apache#13808)

* Update LICENSE File with subcomponents

* Fix JavaScript licenses

* Add copyrights for third party licenses to license file (apache#13851)

* Remove R-package from LICENSE

* Update googletest due to licensing
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Update LICENSE File with subcomponents

* Fix JavaScript licenses
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants