This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix website redirection issues #13796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmarkham
changed the title
roywei
reviewed
Jan 8, 2019
|
It is supposed to redirect faq requests to master. We had some old content in old versions that was inaccurate, so that's why the redirect happens. It does this for install, tutorials, etc - anything that should be current. |
|
I'm working on what might be an even better solution, but I don't want to hold this up. This works and it fixes a problem that should be resolved ASAP, so I'm merging it. |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the htaccess redirection to use a default value (master) and better handles requests coming in from different versions.
Fixes #13740.
Comments
http:https://34.201.8.176/faq/env_var.html - works
http:https://34.201.8.176/versions/master/faq/env_var.html - works
http:https://34.201.8.176/versions/1.4.0/faq/env_var.html - will redirect to master.
Link to env var from http:https://34.201.8.176/faq/index.html#extend-and-contribute-to-mxnet goes to the productions website. There's still some hijacking code going on in the publish step that should be removed so development and testing is easier and less failure prone. So for now, you have to manually enter the address for any links you want to test.
Like this one works fine: http:https://34.201.8.176/versions/master/faq/finetune.html or http:https://34.201.8.176/faq/finetune.html
With regard to why this issue is happening in the first place - I'm not sure. I'm seeing a lot of redirect issues, including the 404 page totally crashing for too many redirects. It works here in this preview. This all worked fine for many months and the htaccess file hasn't been touched in months, so 🤷♂️ - anyway this update seems to resolve the issue for now.
PS - the centos-gpu test finished but was hanging, so I restarted it. These successful runs but with hanging should be investigated!