Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix USE_MKLDNN check in Makefile #13775

Merged
merged 4 commits into from
Jan 6, 2019
Merged

Fix USE_MKLDNN check in Makefile #13775

merged 4 commits into from
Jan 6, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Jan 5, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@TaoLv TaoLv requested a review from szha as a code owner January 5, 2019 04:17
@TaoLv
Copy link
Member Author

TaoLv commented Jan 5, 2019

@szha @xinyu-intel @mseth10 Please review.

@xinyu-intel
Copy link
Contributor

@TaoLv MKL-DNN will not be set to 1 if only make -j http:https://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/unix-gpu/branches/PR-13775/runs/1/nodes/37/steps/139/log/?start=0

pengzhao-intel
pengzhao-intel reviewed Jan 5, 2019
View reviewed changes
make/config.mk
# whether use MKL-DNN library: 0 = disabled, 1 = enabled
# if USE_MKLDNN is not defined, MKL-DNN will be enabled by default on x86 Linux.
# you can disable it explicity with USE_MKLDNN = 0
USE_MKLDNN =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the right value miss?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have different default behavior for different platforms at this time, we cannot have a proper default value for USE_MKLDNN here. So I leave it undefined.

@TaoLv TaoLv mentioned this pull request Jan 6, 2019
Closed
5 tasks
@lanking520
Copy link
Member

@TaoLv Thanks for your contribution. I verified this and it works on my issue too.

lanking520
lanking520 approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@szha szha merged commit 17c8b25 into apache:master Jan 6, 2019
@szha szha mentioned this pull request Jan 6, 2019
Closed
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
@TaoLv
Fix USE_MKLDNN check in Makefile (apache#13775)
d3eb8a0 
* fix makefile

* change make/config.mk

* add comments

* retrigger ci
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@TaoLv
Fix USE_MKLDNN check in Makefile (apache#13775)
057982e 
* fix makefile

* change make/config.mk

* add comments

* retrigger ci
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel left review comments

@lanking520 lanking520 lanking520 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Build Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TaoLv @xinyu-intel @lanking520 @pengzhao-intel @szha