Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1274] Add a test for SGLD optimizer with comparisons for set noise seeds. #13762

Merged
merged 2 commits into from
Jan 16, 2019

Conversation

D-Roberts
Copy link
Contributor

@D-Roberts D-Roberts commented Jan 2, 2019

Description

The SGLD optimizer adds Gaussian noise to the weights updates.
A test is added for the SGLD optimizer and the test passes. The test must use set seeds to be able to compare opt1 and opt2 and compare_optimizer method is updated to allow for this.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add unit test for SGLD optimizer that passes with two different noise seeds.

@Roshrini
Copy link
Member

Roshrini commented Jan 2, 2019

@mxnet-label-bot Add [pr-awaiting-review, Python]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Python labels Jan 2, 2019
@anirudhacharya
Copy link
Member

LGTM

@mxnet-label-bot update [pr-awaiting-merge]

@marcoabreu marcoabreu added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed Python pr-awaiting-review PR is waiting for code review labels Jan 14, 2019
Copy link
Contributor

@stu1130 stu1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit e682169 into apache:master Jan 16, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@D-Roberts D-Roberts deleted the sgld_test branch December 21, 2020 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants