This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Use curl to download sample data instead of wget. #13761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot [scala] |
|
@mxnet-label-bot Add [Scala, pr-awaiting-review] |
lanking520
reviewed
Jan 2, 2019
| @@ -27,7 +27,7 @@ else | |||
| fi | |||
|
|
|||
| # you can get the training data file using the following command | |||
| # wget http:https://data.mxnet.io/data/char_lstm.zip | |||
| # curl -O http:https://data.mxnet.io/data/char_lstm.zip | |||
There was a problem hiding this comment.
-o need a path as parameter,
-O will use file name in url and save in current directory.
| @@ -28,7 +28,7 @@ fi | |||
| # which gpu card to use, -1 means cpu | |||
| GPU=$1 | |||
| # you can get the training data file using the following command | |||
| # wget http:https://data.mxnet.io/data/char_lstm.zip | |||
| # curl -O http:https://data.mxnet.io/data/char_lstm.zip | |||
There was a problem hiding this comment.
downloads with the same name according to the manpage. (man curl)
lanking520
approved these changes
Jan 3, 2019
piyushghai
approved these changes
Jan 3, 2019
|
lgtm. |
rondogency
pushed a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Mac OSX, wget is conflicting with MXNet build (zlib), developer has to uninstall wget from Mac.
Current scala example script using wget to download model and images, make it difficult to mac developers.
This change to workaround this issue form Mac users.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.