This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix the order of error term's operands #13745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep-krishnamurthy
approved these changes
Dec 29, 2018
sandeep-krishnamurthy
added
Gluon
pr-awaiting-merge
python/mxnet/gluon/loss.py
Outdated
| @@ -101,7 +101,7 @@ def hybrid_forward(self, F, x, *args, **kwargs): | |||
| class L2Loss(Loss): | |||
| r"""Calculates the mean squared error between `pred` and `label`. | |||
There was a problem hiding this comment.
by the same reasoning, this should be swapped as label is the subject.
There was a problem hiding this comment.
Thanks, good finding!
|
LGTM! |
stephenrawls
pushed a commit
to stephenrawls/incubator-mxnet
that referenced
this pull request
Feb 16, 2019
* fix the order of error term's operands * address comments
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fix the order of error term's operands * address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error term should be "actual minus predicted".
This PR should be no op, since all related error terms are either squared or transformed into absolute value.