Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ONNX test code cleanup - part 2 #13738

Merged
merged 4 commits into from
Dec 28, 2018

Conversation

vandanavk
Copy link
Contributor

@vandanavk vandanavk commented Dec 27, 2018

Description

Continuing with the test code cleanup in PR #13553, there was an opportunity to make the test caller code more concise. There were 2 files for calling test for mxnet and gluon backend. This PR condenses it to 1 file for calling backend tests.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http:https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Use test suite and TestRunner to execute tests for different backends (mxnet/gluon) and operations (export/import)

Comments

  • Tested all import/export tests

@vandanavk
Copy link
Contributor Author

@mxnet-label-bot add [ONNX, pr-awaiting-review]

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Dec 27, 2018
@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 2f202af into apache:master Dec 28, 2018
rondogency pushed a commit to rondogency/incubator-mxnet that referenced this pull request Jan 9, 2019
* Common test caller

* Remove incorrect comment

* Make corrections to CI

* fix ci script
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Common test caller

* Remove incorrect comment

* Make corrections to CI

* fix ci script
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ONNX pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants